Improve the promise-caching in the PDFDocument.fieldObjects getter
#18871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PR 18845 we're accessing this getter more, hence it seems like a good idea to ensure that the initial `formInfo` access is covered as well. While unlikely to be a problem in practice, at least theoretically that data may not be available and the code in `fieldObjects` could thus currently be *unintentionally* invoked more than once.
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0cd2082ec6dbc40/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1a5a5857f47eac2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1a5a5857f47eac2/output.txt Total script time: 31.32 mins
Image differences available at: http://54.241.84.105:8877/1a5a5857f47eac2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/0cd2082ec6dbc40/output.txt Total script time: 47.16 mins
Image differences available at: http://54.193.163.58:8877/0cd2082ec6dbc40/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 8, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the promise-caching in the
PDFDocument.fieldObjectsgetterAfter PR Fix missing annotation parent in using the one from the Fields entry #18845 we're accessing this getter more, hence it seems like a good idea to ensure that the initial
formInfoaccess is covered as well.While unlikely to be a problem in practice, at least theoretically that data may not be available and the code in
fieldObjectscould thus currently be unintentionally invoked more than once.Reduce duplication in the
PDFDocument.calculationOrderIdsgetterSmaller diff with https://github.com/mozilla/pdf.js/pull/18871/files?w=1